Skip to content

src: register StreamBase while registering LibuvStreamWrap#43321

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
RaisinTen:src/register-StreamBase-while-registering-LibuvStreamWrap
Jun 17, 2022
Merged

src: register StreamBase while registering LibuvStreamWrap#43321
nodejs-github-bot merged 2 commits intonodejs:mainfrom
RaisinTen:src/register-StreamBase-while-registering-LibuvStreamWrap

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

@RaisinTen RaisinTen commented Jun 5, 2022

This resolves this TODO -

node/src/stream_wrap.cc

Lines 111 to 112 in 71071f8

// TODO(joyee): StreamBase::RegisterExternalReferences() is called somewhere
// else but we may want to do it here too and guard it with a static flag.
.

Signed-off-by: Darshan Sen raisinten@gmail.com

cc @joyeecheung

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

@santigimeno santigimeno santigimeno approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@RaisinTen @nodejs-github-bot @jasnell @santigimeno @tniessen @joyeecheung @aduh95